Skip to content

[PM-23585] Migrate desktop settings dialog to CL#20230

Open
Hinton wants to merge 6 commits intomainfrom
desktop/settings
Open

[PM-23585] Migrate desktop settings dialog to CL#20230
Hinton wants to merge 6 commits intomainfrom
desktop/settings

Conversation

@Hinton
Copy link
Copy Markdown
Member

@Hinton Hinton commented Apr 17, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23585

📔 Objective

Migrates the desktop settings dialog to use the modern dialog system with tabs. It also migrates all inputs to use proper design system components.

Note this is a temporary migration while we build out the newer sidebar compatible dialogs.

📸 Screenshots

Screen.Recording.2026-04-17.at.15.36.14.mov

@Hinton Hinton requested review from a team and willmartian April 17, 2026 13:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 64.12698% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.16%. Comparing base (be70072) to head (a53cbb7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ktop/src/app/accounts/settings-dialog.component.ts 64.83% 104 Missing and 5 partials ⚠️
apps/desktop/src/app/app.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20230      +/-   ##
==========================================
+ Coverage   47.11%   47.16%   +0.04%     
==========================================
  Files        3951     3952       +1     
  Lines      119722   120058     +336     
  Branches    18346    18393      +47     
==========================================
+ Hits        56407    56622     +215     
- Misses      59081    59198     +117     
- Partials     4234     4238       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

Logo
Checkmarx One – Scan Summary & Detailsdffca475-1ff8-412c-b153-0716429a0c0f


New Issues (1) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 MEDIUM Missing_HSTS_Header libs/common/src/services/api.service.ts: 206
detailsThe web-application does not define an HSTS header, leaving it vulnerable to attack.
Attack Vector

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant